Patch codegen issues enough to make tests pass in experimental analysis #14660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekpyron
approved these changes
Oct 31, 2023
|
Argh, looks like I somehow missed |
cameel
force-pushed
the
new-analysis-patch-codegen-issues-to-make-tests-pass
branch
from
e78811e to
82d27c8
Compare
|
Looks like it's because the new-style not only have a separate return parameter list but the original list is no longer populated. So |
cameel
force-pushed
the
new-analysis-patch-codegen-issues-to-make-tests-pass
branch
from
82d27c8 to
71d8fe3
Compare
cameel
deleted the
new-analysis-patch-codegen-issues-to-make-tests-pass
branch
cameel
added a commit
that referenced
this pull request
Dec 8, 2023
…sues-to-make-tests-pass Patch codegen issues enough to make tests pass in experimental analysis
6 tasks
cameel
added a commit
that referenced
this pull request
Dec 13, 2023
…sues-to-make-tests-pass Patch codegen issues enough to make tests pass in experimental analysis
cameel
added a commit
that referenced
this pull request
Dec 13, 2023
…sues-to-make-tests-pass Patch codegen issues enough to make tests pass in experimental analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this should let us finally get rid of the hack that disables the codegen in syntax tests. Note that the codegen won't actually run until we remove the hack commit from
newAnalysisbranch.The PR patches two issues that prevent all current test cases from pass through codegen successfully:
builtin_type_definition.sol: Calls via function pointers seem unimplemented. I added a propersolUnimplementedAssert()against that.import_and_call_stdlib_function.sol: Codegen unconditionally assigns function result to a variable even if the function does not return anything (which is invalid Yul). Added anifto skip that for functions without return parameters.These are not proper fixes, but should be good enough until we address the issues properly. Especially the second one should be addressed by #14620.